Implement benchmarking CI for python#8261
Merged
NaderAlAwar merged 13 commits intoNVIDIA:mainfrom Apr 10, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alliepiper
approved these changes
Apr 9, 2026
Contributor
alliepiper
left a comment
There was a problem hiding this comment.
This is great, and thanks for the QoL improvement to the compare script! Much more readable in CI now 🫡
Comment on lines
+28
to
+36
| cub: | ||
| filters: | ||
| # Examples: | ||
| # - '^cub\.bench\.for_each\.base' | ||
| # - '^cub\.bench\.reduce\.(sum|min)\.' | ||
|
|
||
| # Python benchmark filters (regex matched against paths under benchmarks/). | ||
| python: | ||
| filters: |
Contributor
There was a problem hiding this comment.
non-critical suggestion:
filters:
cub:
...
python:
...might be cleaner unless we intend to add more project-specific options.
Contributor
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 14m: Pass: 100%/445 | Total: 5d 13h | Max: 1h 43m | Hits: 99%/515440See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #8237
You can now specify python benchmarks in addition to CUB benchmarks in
bench.yamlBenchmarks tested in CI with
[bench-only]on L4 — https://github.com/NVIDIA/cccl/actions/runs/23857060086/job/69553320225?pr=8261 (CUB only) and https://github.com/NVIDIA/cccl/actions/runs/23866054665 (CUB and Python)Python benchmarks tested locally on RTX 6000 Ada (sm_89, CUDA 13.1):
compute/reduce/sum.py— full compare pipeline end-to-endreduce.min(CUB) +compute/reduce/{sum,min,custom}.py(Python)parse_bench_matrix.shvalidated for CUB-only, Python-only, both, and template-rejectioncases
New
--no-colorflag innvbench_compare.pyfor better formatting in github markdown https://github.com/NVIDIA/cccl/actions/runs/23918641066