Skip to content

Implement benchmarking CI for python#8261

Merged
NaderAlAwar merged 13 commits intoNVIDIA:mainfrom
NaderAlAwar:benchmark-ci-for-python
Apr 10, 2026
Merged

Implement benchmarking CI for python#8261
NaderAlAwar merged 13 commits intoNVIDIA:mainfrom
NaderAlAwar:benchmark-ci-for-python

Conversation

@NaderAlAwar
Copy link
Copy Markdown
Contributor

@NaderAlAwar NaderAlAwar commented Apr 1, 2026

Description

closes #8237

You can now specify python benchmarks in addition to CUB benchmarks in bench.yaml

@NaderAlAwar NaderAlAwar requested review from a team as code owners April 1, 2026 15:34
@NaderAlAwar NaderAlAwar requested a review from gonidelis April 1, 2026 15:34
@NaderAlAwar NaderAlAwar requested a review from elstehle April 1, 2026 15:34
@github-project-automation github-project-automation bot moved this to Todo in CCCL Apr 1, 2026
@NaderAlAwar NaderAlAwar requested a review from tpn April 1, 2026 15:34
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Apr 1, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@NaderAlAwar NaderAlAwar requested a review from alliepiper April 1, 2026 20:57
@github-actions

This comment has been minimized.

@NaderAlAwar NaderAlAwar requested a review from a team as a code owner April 2, 2026 19:41
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, and thanks for the QoL improvement to the compare script! Much more readable in CI now 🫡

Comment thread ci/bench.template.yaml Outdated
Comment on lines +28 to +36
cub:
filters:
# Examples:
# - '^cub\.bench\.for_each\.base'
# - '^cub\.bench\.reduce\.(sum|min)\.'

# Python benchmark filters (regex matched against paths under benchmarks/).
python:
filters:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-critical suggestion:

filters:
  cub:
    ...
  python:
    ...

might be cleaner unless we intend to add more project-specific options.

@github-actions
Copy link
Copy Markdown
Contributor

❌ Benchmark Results

Benchmark comparison had failures.

Results
Artifacts

@NaderAlAwar NaderAlAwar enabled auto-merge (squash) April 10, 2026 01:13
@github-actions
Copy link
Copy Markdown
Contributor

🥳 CI Workflow Results

🟩 Finished in 2h 14m: Pass: 100%/445 | Total: 5d 13h | Max: 1h 43m | Hits: 99%/515440

See results here.

@NaderAlAwar NaderAlAwar merged commit 451630a into NVIDIA:main Apr 10, 2026
461 of 464 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[cuda.compute]: Add Benchmark CI for cuda.compute

2 participants